Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TopologyAwareScheduling enabled by default for Kueue v0.9.1 #3396

Merged

Conversation

sharabiani
Copy link
Collaborator

This PR enables TopologyAwareScheduling by default for Kueue v0.9.1 installation.
It is already enabled for its v0.9.0.

@sharabiani sharabiani added the release-module-improvements Added to release notes under the "Module Improvements" heading. label Dec 12, 2024
@sharabiani sharabiani self-assigned this Dec 12, 2024
@annuay-google
Copy link
Contributor

Can you please expand the PR description with:

  • What are the consequences of enabling TAS by default?
  • Why do we need to this enabled by default?
  • How have we verified this change is safe?

@ighosh98 ighosh98 self-requested a review December 12, 2024 16:48
Copy link
Contributor

@ighosh98 ighosh98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sharabiani sharabiani merged commit 64f812e into GoogleCloudPlatform:develop Dec 12, 2024
9 of 62 checks passed
@nick-stroud nick-stroud mentioned this pull request Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-module-improvements Added to release notes under the "Module Improvements" heading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants